wgtmac commented on code in PR #3: URL: https://github.com/apache/iceberg-cpp/pull/3#discussion_r1865407281
########## include/CMakeLists.txt: ########## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: The `include` folder is for public header files that will be exported and installed. I'm also fine to move them next to the cc files. In that case, I think it would be better to add `_internal.h` suffix to non-exported header files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
