Fokko commented on code in PR #11670:
URL: https://github.com/apache/iceberg/pull/11670#discussion_r1863168496


##########
site/docs/community.md:
##########
@@ -76,7 +76,9 @@ Iceberg has four mailing lists:
 
 The Apache Iceberg community is built on the principles described in the 
[Apache Way](https://www.apache.org/theapacheway/index.html) 
 and all who engage with the community are expected to be respectful, open, 
come with the best interests of the community in mind, 
-and abide by the Apache Foundation [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct.html). 
+and abide by the Apache Foundation [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct.html).

Review Comment:
   ```suggestion
   and abide by the Apache Software Foundation [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct.html).
   ```



##########
site/docs/community.md:
##########
@@ -100,3 +102,56 @@ Recruitment of community members should not be conducted 
through direct messages
 related to contributing to or using Iceberg can be posted to the `#jobs` 
channel. 
 
 For questions regarding any of the guidelines above, please contact a PMC 
member
+
+## The Path from Contributor to Committer
+
+Many contributors have questions about how to become a committer. This section 
outlines what committers do and how they are invited.
+
+### What are the responsibilities of a committer?
+
+In the Iceberg project, committers are community members that can review and 
commit changes to Iceberg repositories. Reviewing is the primary responsibility 
of committers.
+
+### How are new committers added?
+
+Starting from the foundation guidelines, committers are nominated and 
discussed by the PMC, which uses a consensus vote to confirm a new committer. 
This vote is the only formal requirement in the Iceberg community — there are 
no other requirements, such as a minimum period of time or a minimum number of 
contributions. Similarly, there is no length of time or number of commits that 
automatically qualify someone to be a committer.
+
+Committers are added when someone has built trust with PMC members that they 
have good judgment and are a reliable reviewer.

Review Comment:
   Hey JB, thanks for linking that page. I was surprised that this page changed 
so substantially to how it was before, as an effort of deduplication: 
https://github.com/apache/comdev-site/pull/191/files#diff-f61968335feadda8b65024fba3abbee7ffe36f56ad106968f47927a9b286f290
   
   This is my take. It depends on the project. For another project I worked on, 
the risk of accidentally committing a bug is fairly low, while on Iceberg there 
is a chance of data loss or incorrectness. Which would be a real threat to the 
project. As always, wording is subjective, and also cultural. If we feel like 
extending this, I would rather go with something like: 
   
   > Someone who's committed to the project and helping the community.
   
   But I would leave it as it is now as it boils down to the essence, and it 
isn't set in stone either (in git actually).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to