kevinjqliu commented on code in PR #1388: URL: https://github.com/apache/iceberg-python/pull/1388#discussion_r1862579074
########## pyiceberg/table/__init__.py: ########## @@ -1493,6 +1496,13 @@ def to_ray(self) -> ray.data.dataset.Dataset: return ray.data.from_arrow(self.to_arrow()) + def count(self) -> int: + res = 0 + tasks = self.plan_files() Review Comment: this count will not be accurate when there are deletes files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org