kevinjqliu commented on code in PR #1383:
URL: https://github.com/apache/iceberg-python/pull/1383#discussion_r1861073730
##########
pyiceberg/manifest.py:
##########
@@ -957,7 +957,11 @@ def __init__(self, output_file: OutputFile, snapshot_id:
int, parent_snapshot_id
super().__init__(
format_version=1,
output_file=output_file,
- meta={"snapshot-id": str(snapshot_id), "parent-snapshot-id":
str(parent_snapshot_id), "format-version": "1"},
+ meta={
+ "snapshot-id": str(snapshot_id),
+ "parent-snapshot-id": str(parent_snapshot_id) if
parent_snapshot_id is not None else "null",
Review Comment:
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/ManifestListWriter.java#L116
java `String.valueOf(parentSnapshotId)` produces "null" string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
