jdockerty commented on code in PR #710:
URL: https://github.com/apache/iceberg-rust/pull/710#discussion_r1860831288
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -382,12 +382,15 @@ impl ArrowSchemaVisitor for ArrowSchemaConverter {
DataType::Time64(unit) if unit == &TimeUnit::Microsecond => {
Ok(Type::Primitive(PrimitiveType::Time))
}
- DataType::Timestamp(unit, None) if unit == &TimeUnit::Microsecond
=> {
+ DataType::Timestamp(unit, None)
+ if unit == &TimeUnit::Microsecond || unit ==
&TimeUnit::Nanosecond =>
+ {
Ok(Type::Primitive(PrimitiveType::Timestamp))
Review Comment:
Ah! I was looking at the wrong thing when I was wiring this up, my fault
:facepalm:
I've adjusted these types to the `*Ns` variants :+1: Thank you :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
