pvary commented on code in PR #11662:
URL: https://github.com/apache/iceberg/pull/11662#discussion_r1860565686
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestDataStatisticsOperator.java:
##########
@@ -136,6 +137,27 @@ public void testProcessElement(StatisticsType type) throws
Exception {
}
}
+ @ParameterizedTest
+ @EnumSource(StatisticsType.class)
+ public void testProcessElementWithNull(StatisticsType type) throws Exception
{
+ DataStatisticsOperator operator = createOperator(type,
Fixtures.NUM_SUBTASKS);
+ try (OneInputStreamOperatorTestHarness<RowData, StatisticsOrRecord>
testHarness =
+ createHarness(operator)) {
+ StateInitializationContext stateContext = getStateContext();
+ operator.initializeState(stateContext);
+ operator.processElement(new StreamRecord<>(GenericRowData.of(null,
5)));
+ operator.processElement(new
StreamRecord<>(GenericRowData.of(StringData.fromString("a"), 3)));
+
+ DataStatistics localStatistics = operator.localStatistics();
+ SortKeySerializer sortKeySerializer = new
SortKeySerializer(Fixtures.SCHEMA, Fixtures.SORT_ORDER);
+ DataStatisticsSerializer taskStatisticsSerializer = new
DataStatisticsSerializer(sortKeySerializer);
+ DataOutputSerializer outputView = new DataOutputSerializer(1024);
+
+ taskStatisticsSerializer.serialize(localStatistics, outputView);
+ testHarness.endInput();
Review Comment:
We should check if the resulting statistics is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
