liurenjie1024 commented on PR #715: URL: https://github.com/apache/iceberg-rust/pull/715#issuecomment-2502994521
> Seems this PR caused clippy fail > > ``` > error: use of deprecated field `catalog::TableUpdate::AddSchema::last_column_id`: This field is handled internally, and should not be part of the update. > --> crates/iceberg/src/catalog/mod.rs:458:17 > | > 458 | last_column_id, > | ^^^^^^^^^^^^^^ > | > = note: `-D deprecated` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(deprecated)]` > ``` > > Should we mark it as #[allow(deprecated)]? I don't think we should add a mark, submitted a pr to fix it: https://github.com/apache/iceberg-rust/pull/717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
