manuzhang commented on code in PR #11123:
URL: https://github.com/apache/iceberg/pull/11123#discussion_r1857531933
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -145,22 +146,26 @@ public Table loadTable(TableIdentifier ident) {
}
if (MetadataTableUtils.hasMetadataTableName(canonicalized)) {
Review Comment:
The issue is not`NoSuchTableException` will ever be thrown on cache miss
since `catalog::loadTable` can successfully load the metadata table. For
example, in `BaseMetastoreCatalog`
https://github.com/apache/iceberg/blob/fa00482d3fb45a053d9569f82983295a5c6a7499/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L45-L71
In this case, we don't cache the original table and change the current
behavior.
##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -145,22 +146,26 @@ public Table loadTable(TableIdentifier ident) {
}
if (MetadataTableUtils.hasMetadataTableName(canonicalized)) {
Review Comment:
The issue is no`NoSuchTableException` will ever be thrown on cache miss
since `catalog::loadTable` can successfully load the metadata table. For
example, in `BaseMetastoreCatalog`
https://github.com/apache/iceberg/blob/fa00482d3fb45a053d9569f82983295a5c6a7499/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L45-L71
In this case, we don't cache the original table and change the current
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
