JasperHG90 commented on issue #1363:
URL:
https://github.com/apache/iceberg-python/issues/1363#issuecomment-2495318937
I've annotated this method with what I see in the debugger
```python
@retry(**_RETRY_ARGS)
def table_exists(self, identifier: Union[str, Identifier]) -> bool:
"""Check if a table exists.
Args:
identifier (str | Identifier): Table identifier.
Returns:
bool: True if the table exists, False otherwise.
"""
identifier_tuple =
self._identifier_to_tuple_without_catalog(identifier) # ('example', 'test')
# Url:
'http://polaris:8181/api/catalog/v1/dagster_example_catalog/namespaces/example/tables/table'
response = self._session.head(
self.url(Endpoints.load_table, prefixed=True,
**self._split_identifier_for_path(identifier_tuple))
)
# Response.status_code is 200
# This code block is skipped
if response.status_code == 404:
return False
elif response.status_code == 204:
return True
try:
response.raise_for_status()
except HTTPError as exc:
self._handle_non_200_response(exc, {})
# And 'False' is returned
return False
```
Polaris is returning a <200> status code, so that's not correct according to
your spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
