pan3793 opened a new pull request, #7734: URL: https://github.com/apache/iceberg/pull/7734
As mentioned in https://github.com/antlr/antlr4/issues/192#issuecomment-15238595 > You can save a great deal of time on correct inputs by using a two-stage parsing strategy. > > 1. Attempt to parse the input using BailErrorStrategy and PredictionMode.SLL. > If no exception is thrown, you know the answer is correct. > 2. If a ParseCancellationException is thrown, retry the parse using the default > settings (DefaultErrorStrategy and PredictionMode.LL). Iceberg's antlr parser code is derived from Spark, and Spark's one is derived from Presto, the original implementation in Presto is wrong. It was identified on Spark and got fixed in SPARK-42552 https://github.com/apache/spark/pull/40835 The Iceberg extended syntax is not complicated enough, I suppose this fix does not have functionality impacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
