Fokko commented on code in PR #11626:
URL: https://github.com/apache/iceberg/pull/11626#discussion_r1853683623
##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -167,7 +167,13 @@ private GenericManifestFile(GenericManifestFile toCopy) {
super(toCopy);
this.avroSchema = toCopy.avroSchema;
this.manifestPath = toCopy.manifestPath;
- this.length = toCopy.length;
+ try {
+ this.length = toCopy.length();
+ } catch (UnsupportedOperationException e) {
+ // Can be removed when embedded manifests are dropped
+ // DummyFileIO does not support .length()
+ this.length = null;
+ }
Review Comment:
See
https://github.com/apache/iceberg/blob/a52afdc484f9e63477b96d0182586692daac8eab/core/src/main/java/org/apache/iceberg/SnapshotParser.java#L179-L218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
