binayakd commented on code in PR #1354:
URL: https://github.com/apache/iceberg-python/pull/1354#discussion_r1853343720
##########
tests/io/test_pyarrow_stats.py:
##########
@@ -681,6 +681,73 @@ def test_stats_types(table_schema_nested: Schema) -> None:
]
+def construct_test_table_without_stats() -> Tuple[pq.FileMetaData,
Union[TableMetadataV1, TableMetadataV2]]:
Review Comment:
Updated the existing function to take in a `write_statistics` argument,
which can be `bool` or `list`:
```python
def construct_test_table(
write_statistics: bool | List[str] = True,
) -> Tuple[pq.FileMetaData, Union[TableMetadataV1, TableMetadataV2]]:
```
so that it can passed directly to the `ParquetWriter`:
```python
with pa.BufferOutputStream() as f:
with pq.ParquetWriter(
f, table.schema, metadata_collector=metadata_collector,
write_statistics=write_statistics
) as writer:
writer.write_table(table)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
