Fokko commented on code in PR #1359:
URL: https://github.com/apache/iceberg-python/pull/1359#discussion_r1852939525
##########
mkdocs/docs/how-to-release.md:
##########
@@ -74,48 +89,49 @@ export VERSION_BRANCH=${VERSION_WITHOUT_RC//./-}
export GIT_TAG=pyiceberg-${VERSION}
git tag -s ${GIT_TAG} -m "PyIceberg ${VERSION}"
-git push apache ${GIT_TAG}
-
-export GIT_TAG_REF=$(git show-ref ${GIT_TAG})
-export GIT_TAG_HASH=${GIT_TAG_REF:0:40}
-export LAST_COMMIT_ID=$(git rev-list ${GIT_TAG} 2> /dev/null | head -n 1)
+git push [email protected]:apache/iceberg-python.git ${GIT_TAG}
```
-The `-s` option will sign the commit. If you don't have a key yet, you can
find the instructions
[here](http://www.apache.org/dev/openpgp.html#key-gen-generate-key). To install
gpg on a M1 based Mac, a couple of additional steps are required:
<https://gist.github.com/phortuin/cf24b1cca3258720c71ad42977e1ba57>.
-If you have not published your GPG key in
[KEYS](https://downloads.apache.org/iceberg/KEYS) yet, you must publish it
before sending the vote email by doing:
-
-```bash
-svn co https://dist.apache.org/repos/dist/release/iceberg icebergsvn
-cd icebergsvn
-echo "" >> KEYS # append a newline
-gpg --list-sigs <YOUR KEY ID HERE> >> KEYS # append signatures
-gpg --armor --export <YOUR KEY ID HERE> >> KEYS # append public key block
-svn commit -m "add key for <YOUR NAME HERE>"
-```
+### Publish Release Candidate (RC)
-### Upload to Apache SVN
+#### Upload to Apache Dev SVN
-Both the source distribution (`sdist`) and the binary distributions (`wheels`)
need to be published for the RC. The wheels are convenient to avoid having
people to install compilers locally. The downside is that each architecture
requires its own wheel. [use
`cibuildwheel`](https://github.com/pypa/cibuildwheel) runs in Github actions to
create a wheel for each of the architectures.
+##### Create Artifacts for SVN
-Before committing the files to the Apache SVN artifact distribution SVN hashes
need to be generated, and those need to be signed with gpg to make sure that
they are authentic.
+Run the [`Python release` Github
Action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml).
-Go to [Github Actions and run the `Python release`
action](https://github.com/apache/iceberg-python/actions/workflows/python-release.yml).
**Set the version to main, since we cannot modify the source**.
+* Tag: Use the newly created tag.
+* Version: Set the `version` to `main`, as the source cannot be modified.
-Download the zip, and sign the files:
+This action will generate:
+
+* Source distribution (`sdist`)
+* Binary distributions (`wheels`) for each architectures. These are created
using [`cibuildwheel`](https://github.com/pypa/cibuildwheel)
+
+##### Download Artifacts, Sign, and Generate Checksums
+
+Download the ZIP file containing the artifacts from the GitHub Actions run and
unzip it.
+
+Navigate to the release directory. Sign the files and generate checksums:
+
+* `.asc` files: GPG-signed versions of each artifact to ensure authenticity.
+* `.sha512` files: SHA-512 checksums for verifying file integrity.
```bash
cd release-main/
for name in $(ls pyiceberg-*.whl pyiceberg-*.tar.gz)
do
- gpg --yes --armor --local-user [email protected] --output "${name}.asc"
--detach-sig "${name}"
Review Comment:
lol, thanks! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
