vincenzon commented on issue #1357: URL: https://github.com/apache/iceberg-python/issues/1357#issuecomment-2491905990
According to this: https://spark.apache.org/docs/latest/sql-ref-identifier.html it is allowed. In fact, the way quoting is handled by pyiceberg is wrong on two levels: - The quote should be backtick not double quote. - The logic [here](https://github.com/apache/iceberg-python/blob/7a83695330518bea0dee589b5b513297c4d59b66/pyiceberg/expressions/parser.py#L83C21-L83C72) just qoutes an identifier that conforms to the unquoted specification. Quotes are typically used to allow non-conforming identifier names. Fixing the quote character is easy, fixing the second issue would be more involved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
