bryanck commented on code in PR #11599:
URL: https://github.com/apache/iceberg/pull/11599#discussion_r1852504069


##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -180,6 +181,12 @@ private static ConfigDef newConfigDef() {
         DEFAULT_CONTROL_TOPIC,
         Importance.MEDIUM,
         "Name of the control topic");
+    configDef.define(
+            CONTROL_GROUP_ID_PREFIX_PROP,
+            ConfigDef.Type.STRING,
+            DEFAULT_CONTROL_GROUP_PREFIX,
+            Importance.LOW,
+            "Prefix of the control consumer group, should not be set under 
normal conditions");

Review Comment:
   I think it is reasonable to set this, so I'd make this `Prefix of the 
control consumer group`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to