Fokko commented on code in PR #1304:
URL: https://github.com/apache/iceberg-python/pull/1304#discussion_r1850849714
##########
mkdocs/docs/api.md:
##########
@@ -122,32 +122,13 @@ schema = Schema(
),
)
-from pyiceberg.partitioning import PartitionSpec, PartitionField
Review Comment:
Love it, thanks for cleaning this up!
##########
pyiceberg/catalog/__init__.py:
##########
@@ -754,9 +760,7 @@ def _load_file_io(self, properties: Properties =
EMPTY_DICT, location: Optional[
return load_file_io({**self.properties, **properties}, location)
@staticmethod
- def _convert_schema_if_needed(schema: Union[Schema, "pa.Schema"]) ->
Schema:
- if isinstance(schema, Schema):
- return schema
+ def _convert_to_iceberg_schema(schema: "pa.Schema") -> Schema:
Review Comment:
It could be that folks are using this method, I would refrain from changing
it when not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
