nastra commented on code in PR #11545:
URL: https://github.com/apache/iceberg/pull/11545#discussion_r1848165705
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackPositionDeletesRewriter.java:
##########
@@ -107,12 +108,16 @@ protected void doRewrite(String groupId,
List<PositionDeletesScanTask> group) {
// keep only valid position deletes
Dataset<Row> dataFiles = dataFiles(partitionType, partition);
- Column joinCond =
posDeletes.col("file_path").equalTo(dataFiles.col("file_path"));
+ Column joinCond =
+ posDeletes
+ .col(MetadataColumns.DELETE_FILE_PATH.name())
Review Comment:
mainly to make it easier to see that those columns refer to the ones from
the `PositionDeletesTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
