HonahX commented on code in PR #1332:
URL: https://github.com/apache/iceberg-python/pull/1332#discussion_r1847527528
##########
pyiceberg/catalog/hive.py:
##########
@@ -651,7 +651,7 @@ def list_tables(self, namespace: Union[str, Identifier]) ->
List[Identifier]:
for table in open_client.get_table_objects_by_name(
dbname=database_name,
tbl_names=open_client.get_all_tables(db_name=database_name)
)
- if table.parameters[TABLE_TYPE].lower() == ICEBERG
+ if table.parameters.get("table_type", "").lower() == ICEBERG
Review Comment:
```suggestion
if table.parameters.get(TABLE_TYPE, "").lower() == ICEBERG
```
Just one minor thing: How about using constant `TABLE_TYPE` defined in
`catalog/__init__.py` here? I just realized I forgot to mention this in #1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
