rocco408 commented on issue #11541: URL: https://github.com/apache/iceberg/issues/11541#issuecomment-2481603847
I have a few questions to help get started. 1. Is [TestRemoveOrphanFilesProcedure](https://github.com/apache/iceberg/blob/acd7cc1126b192ccb53ad8198bda37e983aa4c6c/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java#L70) a good place to add a new test for this? I found [this issue](https://github.com/apache/iceberg/issues/10539#issue-2362851350), maybe this is a good starting point for codifying the current problem? 2. > branch whenever a Hadoop class is about to be used and use FileIO Is the idea to branch in [DeleteOrphanFilesSparkAction](https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java) or in some other more general location(s)? 3. > we currently have everything we need in SupportPrefixOperations to allow a properly equipped FileIO instance to handle all of RemoveOrphanFiles without using any Hadoop Classes I see `SupportPrefixOperations` has 5 FileIO implementations. Is the idea to lean on [ResolvingFileIO](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java#L46-L50) for selecting the appropriate FileIO implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
