Re: [PR] Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner [iceberg]

[via GitHub]

mayankvadariya commented on PR #10858:
URL: https://github.com/apache/iceberg/pull/10858#issuecomment-2471482802

   This change seem to have affected nested namespace support.
   
   With encoded params, `queryParams` are further encoded in `URIBuilder`.
   
   
https://github.com/apache/iceberg/blob/4a3817bc788701973899765ddbdf8b0768c9318a/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java#L230
   
   
   `buildUri(path, queryParams)` generates following output
   
   before
   for `queryParams` containing `parent -> level1level2`
   
`http://localhost:32792/api/catalog/v1/namespaces?parent=level1%1Flevel2&pageToken=`
   
   after
   for `queryParams` containing `parent -> level1%1Flevel2`
   
`http://localhost:32794/api/catalog/v1/namespaces?parent=level1%251Flevel2&pageToken=`
   
   @nastra please advise if we need to revert this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org