AnatolyPopov commented on issue #11505: URL: https://github.com/apache/iceberg/issues/11505#issuecomment-2466749038
Thanks for a quick reply @Fokko! First of all, thanks, building from the tarball you linked above works as expected. However I have several points that I think still should be addressed. I've been taking the sources from the tarball attached to the release here https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.7.0. I would assume that it should as well be buildable, otherwise IMO it does not make too much sense to have it published. The `version.txt` was the first thing I've tried to add after looking into exactly the same piece of code you linked above but it does not help because there is still no `iceberg-build.properties` so the build crashes with `> Task :generateGitProperties FAILED` as expected. I would expect both `version.txt` and `iceberg-build.properties` to be included in release tarball attached to GitHub release as well. Also I can see that `iceberg-build.properties` from the official tarball you linked above is different from the one that is generated from sources and is lacking the tag `apache-iceberg-1.7.0` in `git.tags` property. This seems to be a little misleading when build properties from official release tarball include only release candidate tag `apache-iceberg-1.7.0-rc1`. And one more thing is that even if I clone the repo, checkout the tag, and without manually creating `version.txt` will try to run `assembleDist` I will get `1.8.0-SNAPSHOT` version. As mentioned in https://github.com/apache/iceberg/issues/11506 I think people would expect to be able to build an artifact with the release version from a release commit without manual modifications. Am I missing something at this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
