mark-major commented on code in PR #1307:
URL: https://github.com/apache/iceberg-python/pull/1307#discussion_r1835156235
##########
pyiceberg/catalog/glue.py:
##########
@@ -305,7 +308,18 @@ def __init__(self, name: str, **properties: Any):
aws_secret_access_key=get_first_property_value(properties,
GLUE_SECRET_ACCESS_KEY, AWS_SECRET_ACCESS_KEY),
aws_session_token=get_first_property_value(properties,
GLUE_SESSION_TOKEN, AWS_SESSION_TOKEN),
)
- self.glue: GlueClient = session.client("glue",
endpoint_url=properties.get(GLUE_CATALOG_ENDPOINT))
+ self.glue: GlueClient = session.client(
+ "glue",
+ endpoint_url=properties.get(GLUE_CATALOG_ENDPOINT),
+ config=Config(
+ retries={
+ "max_attempts": get_first_property_value(properties,
GLUE_MAX_RETRIES)
+ if get_first_property_value(properties, GLUE_MAX_RETRIES)
+ else MAX_RETRIES,
+ "mode": "standard",
Review Comment:
I would rather not have that as an option. Standard mode is a more mature
implementation compared to the legacy one.Adaptive mode is still considered
'experimental' which is not something I'd use in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
