Fokko commented on code in PR #1300:
URL: https://github.com/apache/iceberg-python/pull/1300#discussion_r1831655564
##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -98,6 +99,7 @@ def __init__(self, name: str, **properties: str):
session = boto3.Session(
profile_name=properties.get(DYNAMODB_PROFILE_NAME),
region_name=get_first_property_value(properties, DYNAMODB_REGION,
AWS_REGION),
+ botocore_session=properties.get(DEPRECATED_BOTOCORE_SESSION),
Review Comment:
Do we want to emit a deprecation message? I feel like there is no strong
consensus on how to move this forward, and I would also love to get @HonahX's
input on it. Same for Glue below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
