nastra commented on code in PR #11461: URL: https://github.com/apache/iceberg/pull/11461#discussion_r1831126084
########## site/docs/how-to-release.md: ########## @@ -422,7 +422,7 @@ spark-runtime jar for the Spark installation): ```bash spark-shell \ --conf spark.jars.repositories=${MAVEN_URL} \ - --packages org.apache.iceberg:iceberg-spark3-runtime:{{ icebergVersion }} \ + --packages org.apache.iceberg:iceberg-spark-runtime-${SPARK_VERSION}_${SCALA_VERSION}:{{ icebergVersion }} \ Review Comment: I'd rather just set the variables like this, since this is a `bash` script: ``` # replace these with the correct versions SPARK_VERSION=3.5 SCALA_VERSION=2.12 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org