huaxingao commented on PR #11439: URL: https://github.com/apache/iceberg/pull/11439#issuecomment-2458700123
@ludlows Thanks for the PR. I have a couple of questions: 1. It seems to me that the tests don't really test the changes in this PR; they would pass even without the fix. I think we should add some tests that would fail without the fix but can pass with it. 3. Do we want to make the Spark SQL configuration `spark.sql.caseSensitive` apply to Iceberg stored procedure parameters? If so, we probably should apply `spark.sql.caseSensitive` to all Iceberg stored procedure parameters. Are there other Iceberg stored procedure parameters that should also honor `spark.sql.caseSensitive`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
