aokolnychyi opened a new pull request, #11476:
URL: https://github.com/apache/iceberg/pull/11476

   This PR adds a base DV file writer with basic tests. More tests to come once 
we support DV reads.
   
   ```
   Benchmark                                                           
(deletedRowsRatio)  (referencedDataFileCount)  Mode  Cnt           Score        
 Error   Units
   DVWriterBenchmark.dv                                                         
     0.01                          5    ss   10           0.062 ±       0.003   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.01                          5    ss   10           0.219 ±       0.017   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.01                          5    ss   10           0.146 ±       0.006   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.01                         10    ss   10           0.103 ±       0.010   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.01                         10    ss   10           0.435 ±       0.016   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.01                         10    ss   10           0.265 ±       0.014   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.03                          5    ss   10           0.136 ±       0.006   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.03                          5    ss   10           0.479 ±       0.018   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.03                          5    ss   10           0.337 ±       0.018   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.03                         10    ss   10           0.219 ±       0.013   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.03                         10    ss   10           0.918 ±       0.028   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.03                         10    ss   10           0.618 ±       0.014   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.05                          5    ss   10           0.218 ±       0.014   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.05                          5    ss   10           0.696 ±       0.010   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.05                          5    ss   10           0.527 ±       0.008   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.05                         10    ss   10           0.366 ±       0.011   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.05                         10    ss   10           1.389 ±       0.024   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.05                         10    ss   10           0.986 ±       0.007   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.10                          5    ss   10           0.307 ±       0.007   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.10                          5    ss   10           1.179 ±       0.039   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.10                          5    ss   10           1.004 ±       0.010   
 s/op
   
   DVWriterBenchmark.dv                                                         
     0.10                         10    ss   10           0.594 ±       0.006   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
     0.10                         10    ss   10           2.260 ±       0.039   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
     0.10                         10    ss   10           2.045 ±       0.054   
 s/op
   
   DVWriterBenchmark.dv                                                         
      0.2                          5    ss   10           0.709 ±       0.011   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
      0.2                          5    ss   10           2.151 ±       0.017   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
      0.2                          5    ss   10           1.969 ±       0.046   
 s/op
   
   DVWriterBenchmark.dv                                                         
      0.2                         10    ss   10           1.370 ±       0.047   
 s/op
   DVWriterBenchmark.fileScopedParquetDeletes                                   
      0.2                         10    ss   10           4.386 ±       0.034   
 s/op
   DVWriterBenchmark.partitionScopedParquetDeletes                              
      0.2                         10    ss   10           3.849 ±       0.030   
 s/op
   ```
   
   This work is part of #11122.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to