aokolnychyi commented on code in PR #11467:
URL: https://github.com/apache/iceberg/pull/11467#discussion_r1829495298
##########
core/src/main/java/org/apache/iceberg/util/ContentFileUtil.java:
##########
@@ -84,4 +85,17 @@ public static String referencedDataFileLocation(DeleteFile
deleteFile) {
CharSequence location = referencedDataFile(deleteFile);
return location != null ? location.toString() : null;
}
+
+ public static boolean isDV(DeleteFile deleteFile) {
Review Comment:
This is actually intentional. I originally wanted to move `ContentFileUtil`
to `api` but then we decided against that, as it required moving more classes
and increasing the API surface. Therefore, we added a simple utility for what
was needed in `api`. I do want `ContentFileUtil` to contain all the logic for
content files, it is just a matter of one duplicate method. I made that method
in `ScanTaskUtil` private on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
