nastra commented on PR #11470:
URL: https://github.com/apache/iceberg/pull/11470#issuecomment-2456419827
I'd rather try and fix it slightly differently:
```
+ @TempDir private File location;
+
private static SparkSession spark = null;
private static JavaSparkContext sc = null;
@@ -140,14 +141,12 @@ public class TestDataFrameWrites extends
ParameterizedAvroDataTest {
@Override
protected void writeAndValidate(Schema schema) throws IOException {
- File location = createTableFolder();
Table table = createTable(schema, location);
writeAndValidateWithLocations(table, location, new File(location,
"data"));
}
@TestTemplate
public void testWriteWithCustomDataLocation() throws IOException {
- File location = createTableFolder();
File tablePropertyDataLocation =
temp.resolve("test-table-property-data-dir").toFile();
Table table = createTable(new Schema(SUPPORTED_PRIMITIVES.fields()),
location);
table
@@ -157,13 +156,6 @@ public class TestDataFrameWrites extends
ParameterizedAvroDataTest {
writeAndValidateWithLocations(table, location,
tablePropertyDataLocation);
}
- private File createTableFolder() throws IOException {
- File parent = temp.resolve("parquet").toFile();
- File location = new File(parent, "test");
- assertThat(location.mkdirs()).as("Mkdir should succeed").isTrue();
- return location;
- }
-
private Table createTable(Schema schema, File location) {
HadoopTables tables = new HadoopTables(CONF);
return tables.create(schema, PartitionSpec.unpartitioned(),
location.toString());
@@ -397,7 +389,6 @@ public class TestDataFrameWrites extends
ParameterizedAvroDataTest {
@TestTemplate
public void testFaultToleranceOnWrite() throws IOException {
- File location = createTableFolder();
Schema schema = new Schema(SUPPORTED_PRIMITIVES.fields());
Table table = createTable(schema, location);
@@ -421,13 +412,5 @@ public class TestDataFrameWrites extends
ParameterizedAvroDataTest {
assertThat(snapshotBeforeFailingWrite).isEqualTo(snapshotAfterFailingWrite);
assertThat(resultBeforeFailingWrite).isEqualTo(resultAfterFailingWrite);
-
- while (location.exists()) {
- try {
- FileUtils.deleteDirectory(location);
- } catch (NoSuchFileException e) {
- // ignore NoSuchFileException when a file is already deleted
- }
- }
```
@manuzhang can you try and see whether that fixes the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
