aokolnychyi commented on code in PR #11463:
URL: https://github.com/apache/iceberg/pull/11463#discussion_r1828350898
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -43,6 +53,11 @@ class BitmapPositionDeleteIndex implements
PositionDeleteIndex {
this.deleteFiles = deleteFile != null ? Lists.newArrayList(deleteFile) :
Lists.newArrayList();
}
+ BitmapPositionDeleteIndex(RoaringPositionBitmap bitmap, DeleteFile
deleteFile) {
+ this.bitmap = bitmap;
+ this.deleteFiles = deleteFile != null ? Lists.newArrayList(deleteFile) :
Lists.newArrayList();
Review Comment:
I don't think so. I have this check here to match the constructor above.
There are some legacy code paths that create an index and pass null as
`DeleteFile`. Given that it is a new constructor, we can probably require the
file to be non-null, but it won't be consistent with the constructor above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
