RussellSpitzer opened a new issue, #11465:
URL: https://github.com/apache/iceberg/issues/11465

   ### Feature Request / Improvement
   
   TestMetadataTableReadableMetrics currently hardcodes in the expected size 
into the metrics rows rather than actually checking the sizes from the 
underlying data. This means every time the Parquet version changes (or 
compression or what not) the test needs to be updated. See
   
   
https://github.com/apache/iceberg/commit/b8c2b20237bc9309d34dc96c473e9941d1b2ad58
   
   Ideally we would change this so the expected values we check are only those 
which are not dependent on parquet version or change the test to check against 
the actual values.
   
   See https://github.com/apache/iceberg/pull/11462 for an instance where this 
is complicating things
   
   ### Query engine
   
   None
   
   ### Willingness to contribute
   
   - [ ] I can contribute this improvement/feature independently
   - [ ] I would be willing to contribute this improvement/feature with 
guidance from the Iceberg community
   - [ ] I cannot contribute this improvement/feature at this time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to