pvary commented on code in PR #11249:
URL: https://github.com/apache/iceberg/pull/11249#discussion_r1828046137
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkDistributionMode.java:
##########
@@ -118,9 +118,15 @@ public void before() throws IOException {
public void testShuffleByPartitionWithSchema() throws Exception {
testWriteRow(parallelism, SimpleDataUtil.FLINK_SCHEMA,
DistributionMode.HASH);
if (partitioned) {
- assertThat(partitionFiles("aaa")).isEqualTo(1);
- assertThat(partitionFiles("bbb")).isEqualTo(1);
- assertThat(partitionFiles("ccc")).isEqualTo(1);
+ assertThat(partitionFiles("aaa"))
+ .as("There should be only 1 data file in partition 'aaa'")
+ .isEqualTo(1);
+ assertThat(partitionFiles("bbb"))
+ .as("There should be only 1 data file in partition 'bbb'")
+ .isEqualTo(1);
+ assertThat(partitionFiles("ccc"))
+ .as("There should be only 1 data file in partition 'ccc'")
+ .isEqualTo(1);
Review Comment:
Ok.. I'm fine in both ways, and I agree with the sync effort.
@rodmeneses: What is the history of this difference? Is this intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
