aokolnychyi commented on code in PR #11457:
URL: https://github.com/apache/iceberg/pull/11457#discussion_r1828044356
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##########
@@ -128,6 +131,64 @@ public void setupTableLocation() throws Exception {
this.tableLocation = tableDir.toURI().toString();
}
+ @TestTemplate
+ public void testRewriteManifestsPreservesOptionalFields() throws IOException
{
+ assumeThat(formatVersion).isGreaterThanOrEqualTo(2);
+
+ PartitionSpec spec =
PartitionSpec.builderFor(SCHEMA).identity("c1").build();
+ Map<String, String> options = Maps.newHashMap();
+ options.put(TableProperties.FORMAT_VERSION, String.valueOf(formatVersion));
+ Table table = TABLES.create(SCHEMA, spec, options, tableLocation);
+
+ DataFile dataFile1 = newDataFile(table, "c1=0");
+ DataFile dataFile2 = newDataFile(table, "c1=0");
+ DataFile dataFile3 = newDataFile(table, "c1=0");
+ table
+ .newFastAppend()
+ .appendFile(dataFile1)
+ .appendFile(dataFile2)
+ .appendFile(dataFile3)
+ .commit();
+
+ DeleteFile deleteFile1 = newDeleteFileWithRef(table, dataFile1);
+
assertThat(deleteFile1.referencedDataFile()).isEqualTo(dataFile1.location());
+ table.newRowDelta().addDeletes(deleteFile1).commit();
+
+ DeleteFile deleteFile2 = newDeleteFileWithRef(table, dataFile2);
+
assertThat(deleteFile2.referencedDataFile()).isEqualTo(dataFile2.location());
+ table.newRowDelta().addDeletes(deleteFile2).commit();
+
+ DeleteFile deleteFile3 = newDeleteFileWithRef(table, dataFile3);
+
assertThat(deleteFile3.referencedDataFile()).isEqualTo(dataFile3.location());
+ table.newRowDelta().addDeletes(deleteFile3).commit();
+
+ SparkActions actions = SparkActions.get();
+
+ actions
+ .rewriteManifests(table)
+ .rewriteIf(manifest -> true)
+ .option(RewriteManifestsSparkAction.USE_CACHING, useCaching)
+ .execute();
+
+ table.refresh();
+
+ try (CloseableIterable<FileScanTask> tasks = table.newScan().planFiles()) {
+ for (FileScanTask fileTask : tasks) {
+ DataFile dataFile = fileTask.file();
+ if (dataFile.location().equals(dataFile1.location())) {
+ DeleteFile deleteFile = Iterables.getOnlyElement(fileTask.deletes());
Review Comment:
Good call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
