Fokko commented on code in PR #1283:
URL: https://github.com/apache/iceberg-python/pull/1283#discussion_r1827787976
##########
tests/test_schema.py:
##########
@@ -1200,11 +1200,33 @@ def test_promote_float_to_double() -> None:
assert isinstance(applied.fields[0].field_type, DoubleType)
+def test_promote_long_to_int() -> None:
Review Comment:
Good call, updated 👍
##########
tests/test_schema.py:
##########
@@ -1200,11 +1200,33 @@ def test_promote_float_to_double() -> None:
assert isinstance(applied.fields[0].field_type, DoubleType)
+def test_promote_long_to_int() -> None:
Review Comment:
Good one, added those as well 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
