Fokko commented on issue #1247: URL: https://github.com/apache/iceberg-python/issues/1247#issuecomment-2450831332
I don't think we should block the writes as that's pretty aggressive. What we do today when a table has a sort order, we write the data, but set the sort-order to none: https://github.com/apache/iceberg-python/blob/0cebec48833f75eeca02b1a965112615b1cbc1c8/pyiceberg/io/pyarrow.py#L2461-L2464 This is similar to when you have an existing table and add a sort order. The existing data is unsorted. I don't think the behavior that we have today leads to correctness issues. The main thing is that when you do joins, having a pre-sorted file on the join-key could speed up the join substantially (and also compaction as mentioned earlier). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
