szehon-ho commented on code in PR #11396: URL: https://github.com/apache/iceberg/pull/11396#discussion_r1817399329
########## docs/docs/spark-procedures.md: ########## @@ -393,6 +393,7 @@ Iceberg can compact data files in parallel using Spark with the `rewriteDataFile | `max-concurrent-file-group-rewrites` | 5 | Maximum number of file groups to be simultaneously rewritten | | `partial-progress.enabled` | false | Enable committing groups of files prior to the entire rewrite completing | | `partial-progress.max-commits` | 10 | Maximum amount of commits that this rewrite is allowed to produce if partial progress is enabled | +| `partial-progress.max-failed-commits` | same as `partital-progress.max-commits` | Maximum amount of failed commits that this rewrite can have before job failure, if partial progress is enabled | Review Comment: i think following original javadoc more closely 'that this rewrite can have' => 'is allowed' Opt: same as => value of? (very slightly clearer?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
