HonahX commented on code in PR #1258:
URL: https://github.com/apache/iceberg-python/pull/1258#discussion_r1823751559
##########
pyiceberg/catalog/glue.py:
##########
@@ -784,4 +784,4 @@ def drop_view(self, identifier: Union[str, Identifier]) ->
None:
@staticmethod
def __is_iceberg_table(table: TableTypeDef) -> bool:
- return table["Parameters"] is not None and
table["Parameters"][TABLE_TYPE].lower() == ICEBERG
+ return table.get("Parameters", {}).get("table_type", "").lower() ==
"iceberg"
Review Comment:
One small request,
```suggestion
return table.get("Parameters", {}).get("table_type", "").lower() ==
ICEBERG
```
we can use the ICEBERG constant defined in `catalog/__init__.py` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
