wcy-fdu commented on PR #682: URL: https://github.com/apache/iceberg-rust/pull/682#issuecomment-2445726838
After investigation, I found that although [ProjectionMask::leaves()](https://github.com/apache/iceberg-rust/blob/2f3554b30a05028aef1d46d37209e24e1ed96582/crates/iceberg/src/arrow/reader.rs#L389) does not require column_indices to be in order, creating [PredicateConverter](https://github.com/apache/iceberg-rust/blob/2f3554b30a05028aef1d46d37209e24e1ed96582/crates/iceberg/src/arrow/reader.rs#L381) requires it to be in order, so it has to be sorted here anyway. Therefore, it seems unnecessary to remove sort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
