RussellSpitzer commented on code in PR #11373:
URL: https://github.com/apache/iceberg/pull/11373#discussion_r1821559558
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetSchemaUtil.java:
##########
@@ -61,6 +63,128 @@ public class TestParquetSchemaUtil {
required(116, "dec_38_10", Types.DecimalType.of(38, 10)) // spark's
maximum precision
);
+ private static final Schema ICEBERG_SCHEMA =
Review Comment:
Why are we testing this with an Iceberg Schema? Are we unable to craft the
same thing with just a StructType like the other tests here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
