Fokko commented on code in PR #11283: URL: https://github.com/apache/iceberg/pull/11283#discussion_r1819691281
########## docker/iceberg-rest-adapter-image/Dockerfile: ########## @@ -0,0 +1,44 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +FROM azul/zulu-openjdk:17 as builder + +WORKDIR /app/ +COPY open-api/build/libs/iceberg-open-api-test-fixtures-runtime-*.jar /app/ Review Comment: This multi-stage build just copies the files into the container, which doesn't make much sense. Either we should: - Remove this stage, since it doesn't add any value. In line 23 we copy the jar into the container, and at line 33 we copy it from the builder container into the runner container. - Do the actual build inside this container, which is I think the way to go since it also will make the releases using the CI easier and self-contained (so we don't rely on the JDK of Github Actions). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
