rdblue commented on code in PR #11240: URL: https://github.com/apache/iceberg/pull/11240#discussion_r1813586205
########## format/spec.md: ########## @@ -841,19 +855,45 @@ Notes: ## Delete Formats -This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are not supported in v1. +This section details how to encode row-level deletes in Iceberg delete files. Row-level deletes are added by v2 and are not supported in v1. Deletion vectors are added in v3 and are not supported in v2 or earlier. Position delete files must not be added to v3 tables, but existing position delete files are valid. Review Comment: I don't think that this is the right place for it. The spec should state requirements and these points are covered in more specific requirements. This states the requirement to not add non-DV position delete files to v3 tables, and the section on delete vectors states the requirement that when you write a DV, it must include all existing position deletes for the file: > If a DV is written for a data file, it must replace all previously written position delete files so that when a DV is present, readers can safely ignore matching position delete files. There's a good opportunity to add context down in the v3 section that outlines the changes though. I'll add a note there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
