nastra commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1812850887
##########
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##########
@@ -68,6 +68,7 @@ public class IcebergPigInputFormat<T> extends
InputFormat<Void, T> {
private List<InputSplit> splits;
IcebergPigInputFormat(Table table, String signature) {
+ LOG.warn("Iceberg Pig is now deprecated. It will be removed in Iceberg
1.8.");
Review Comment:
rather than logging a warning the class itself should have a `@deprecated`
annotation
##########
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##########
@@ -68,6 +68,7 @@ public class IcebergPigInputFormat<T> extends
InputFormat<Void, T> {
private List<InputSplit> splits;
IcebergPigInputFormat(Table table, String signature) {
+ LOG.warn("Iceberg Pig is now deprecated. It will be removed in Iceberg
1.8.");
Review Comment:
rather than logging a warning the class itself should have a `@deprecated`
annotation. Same for the other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
