alex-kar commented on code in PR #179:
URL: https://github.com/apache/iceberg-go/pull/179#discussion_r1811640330


##########
cmd/iceberg/main.go:
##########
@@ -70,6 +71,7 @@ type Config struct {
        Uuid     bool `docopt:"uuid"`
        Location bool `docopt:"location"`
        Props    bool `docopt:"properties"`
+       Create   bool `docopt:"create"`

Review Comment:
   @zeroshade I can create test to call `main` function with test arguments:
   ```
   func TestCommands(t *testing.T) {
        os.Args = []string{"iceberg", "create", "namespace", "public"}
        main()
   }
   ```
   But I don't know how could I mock and verify call on `catalog`.
   Otherwise it just tries to connect to real catalog and fails.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to