rdblue commented on code in PR #11372: URL: https://github.com/apache/iceberg/pull/11372#discussion_r1809543509
########## LICENSE: ########## @@ -298,6 +298,7 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Delta Lake. * AssignmentAlignmentSupport is an independent development but UpdateExpressionsSupport in Delta was used as a reference. +* RoaringPositionBitmap is an independent development but RoaringBitmapArray in Delta was used as a reference. Review Comment: In some cases, it looks like the methods were directly translated. For example [`toPosition`](https://github.com/apache/iceberg/pull/11372/files#diff-42b322a03e4e0a70933627efc92563d6e47a7f707267a597fb1a5e94302d6517R293-R295) has a different name, but the same implementation and comment as [`composeFromHighLowBytes`](https://github.com/delta-io/delta/blob/master/spark/src/main/scala/org/apache/spark/sql/delta/deletionvectors/RoaringBitmapArray.scala#L498-L499). It may be better to mention this as a Java implementation based on Delta's Scala implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
