nastra commented on code in PR #11180: URL: https://github.com/apache/iceberg/pull/11180#discussion_r1808913187
########## core/src/test/java/org/apache/iceberg/TestBase.java: ########## @@ -63,7 +63,7 @@ public class TestBase { public static final PartitionSpec SPEC = PartitionSpec.builderFor(SCHEMA).bucket("data", BUCKETS_NUMBER).build(); - static final DataFile FILE_A = + public static final DataFile FILE_A = Review Comment: extending `TestBase` means that the subclass is now a parameterized test, which I don't think we actually need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org