adutra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1808788014
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1009,26 +910,13 @@ private FileIO tableFileIO(SessionContext context,
Map<String, String> config) {
return newFileIO(context, fullConf);
}
- private AuthSession tableSession(Map<String, String> tableConf, AuthSession
parent) {
- Map<String, String> credentials =
Maps.newHashMapWithExpectedSize(tableConf.size());
- for (String prop : tableConf.keySet()) {
- if (TABLE_SESSION_ALLOW_LIST.contains(prop)) {
- credentials.put(prop, tableConf.get(prop));
- }
- }
-
- Pair<String, Supplier<AuthSession>> newSession = newSession(credentials,
tableConf, parent);
- if (null == newSession) {
- return parent;
- }
-
- AuthSession session = tableSessions.get(newSession.first(), id ->
newSession.second().get());
-
- return session != null ? session : parent;
+ private AuthSession tableSession(
Review Comment:
Agreed, we can inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
