manuzhang commented on code in PR #11157:
URL: https://github.com/apache/iceberg/pull/11157#discussion_r1806768662
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -711,7 +719,7 @@ public static void importSparkPartitions(
spec,
stagingDir,
checkDuplicateFiles,
- TableMigrationUtil.migrationService(parallelism));
+ executorService(parallelism));
Review Comment:
We already add `executeWith(ExecutorService service)` to `SnapshotTable` and
`MigrateTable` interfaces and it's more testable than passing `parallelism`.
Hence, I prefer to fix forward if not at high cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
