mark-major commented on code in PR #1145:
URL: https://github.com/apache/iceberg-python/pull/1145#discussion_r1806419626


##########
pyiceberg/catalog/dynamodb.py:
##########
@@ -393,7 +393,7 @@ def drop_namespace(self, namespace: Union[str, Identifier]) 
-> None:
             raise NoSuchNamespaceError(f"Database does not exist: 
{database_name}") from e
 
     def list_tables(self, namespace: Union[str, Identifier]) -> 
List[Identifier]:
-        """List tables under the given namespace in the catalog (including 
non-Iceberg tables).
+        """List Iceberg tables under the given namespace in the catalog.

Review Comment:
   It was quite a long time since I have worked on this, but if I recall 
correctly then yes, DynamoDB returned only Iceberg tables. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to