nastra commented on code in PR #11352:
URL: https://github.com/apache/iceberg/pull/11352#discussion_r1806159950
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -77,6 +83,51 @@ public static TableMetadata newTableMetadata(
return newTableMetadata(schema, spec, SortOrder.unsorted(), location,
properties);
}
+ /**
+ * Deletes the oldest metadata files if {@link
+ * TableProperties#METADATA_DELETE_AFTER_COMMIT_ENABLED} is true.
+ *
+ * @param io file IO
+ * @param base table metadata on which previous versions were based
+ * @param metadata new table metadata with updated previous versions
+ */
+ public static void deleteRemovedMetadataFiles(
Review Comment:
I don't think we should be moving this to `TableMetadata`as this adds
unnecessary dependencies to `TableMetadata` (`FileIO` and
`SupportsBulkOperations`).
@leesf what's the goal of this PR and why do we want to move this method
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
