nastra commented on code in PR #10722:
URL: https://github.com/apache/iceberg/pull/10722#discussion_r1804989952
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1311,11 +1327,19 @@ class LoadViewResult(BaseModel):
- `token`: Authorization bearer token to use for view requests if OAuth2
security is enabled
+ ## Storage Credentials
+
+ Credentials for ADLS / GCS / S3 / ... are provided through the
`storage-credentials` field.
+ Clients should first check whether the respective credentials exist in the
`storage-credentials` field before checking the `config` for credentials.
Review Comment:
I'm fine either way and it seems we have a bunch of other places that use
`should` where `must` could be used as well, so I updated this to `must`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
