nastra commented on code in PR #173:
URL: https://github.com/apache/iceberg-go/pull/173#discussion_r1804185400
##########
catalog/glue.go:
##########
@@ -30,22 +30,40 @@ import (
"github.com/aws/aws-sdk-go-v2/service/glue/types"
)
-const glueTypeIceberg = "ICEBERG"
+const (
+ glueTypeIceberg = "ICEBERG"
+ databaseTypePropsKey = "database_type"
+ tableTypePropsKey = "table_type"
+ descriptionPropsKey = "Description"
+
+ // Database location.
+ locationPropsKey = "Location"
+
+ // Table metadata location pointer.
+ metadataLocationPropsKey = "metadata_location"
Review Comment:
I think you also need to set `previous_metadata_location` when committing:
See
https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/glue.py#L142-L145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
